tests: set --windows_enable_symlinks in bzlmod example #3409
Conversation
The `//tests:version_test_binary_*` targets fail when run on Bazel 8 with Windows with a "permission denied" error with the Python executable. The notable thing about these tests is they're shell tests with a data dependency on the Python program, so a symlink is created to refer to the Python program. As best I can tell, Bazel 8 isn't creating the symlink quite right, so Windows considers the file non-executable. Setting `--windows_enable_symlinks` fixes this, but it isn't clear why. Presumably it's telling Bazel to create symlinks more properly.
Summary of ChangesHello @rickeylev, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a critical issue affecting Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds the --windows_enable_symlinks startup flag to the .bazelrc file for the bzlmod example. This change is intended to fix an issue on Windows with Bazel 8 where symlinks to Python binaries in sh_test data dependencies were not executable. The added flag is correctly specified as a startup option, and the accompanying comment clearly explains the reason for its inclusion. The change is well-targeted and should resolve the described problem without side effects on other operating systems. The implementation looks correct and is ready for merging.
The
//tests:version_test_binary_*targets fail when run on Bazel 8 with Windows with a "permission denied" error with the Python executable. The notable thing about these tests is they're shell tests with a data dependency on the Python program, so a symlink is created to refer to the Python program. As best I can tell, Bazel 8 isn't creating the symlink quite right, so Windows considers the file non-executable.Setting
--windows_enable_symlinksfixes this, but it isn't clear why. Presumably it's telling Bazel to create symlinks more properly.