fix: ignore hidden/inert elements to prevent off-screen clicks in carousels #3393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
1 issue found across 2 files
Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.
<file name="tests/ci/test_clickable_element_filtering.py">
<violation number="1" location="tests/ci/test_clickable_element_filtering.py:12">
This test case expects partially offscreen elements to be filtered out, but the detector only rejects nodes that are fully outside the viewport, so ClickableElementDetector.is_interactive returns True here and the parametrized test fails.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
| @pytest.mark.parametrize("attrs,snapshot,expected", [ | ||
| ({'inert': ''}, DummySnapshotNode(10, 10, 100, 20), False), | ||
| ({'aria-hidden': 'true'}, DummySnapshotNode(10, 10, 100, 20), False), | ||
| ({}, DummySnapshotNode(-10, 10, 100, 20), False), |
Contributor
There was a problem hiding this comment.
This test case expects partially offscreen elements to be filtered out, but the detector only rejects nodes that are fully outside the viewport, so ClickableElementDetector.is_interactive returns True here and the parametrized test fails.
Prompt for AI agents
Address the following comment on tests/ci/test_clickable_element_filtering.py at line 12:
<comment>This test case expects partially offscreen elements to be filtered out, but the detector only rejects nodes that are fully outside the viewport, so ClickableElementDetector.is_interactive returns True here and the parametrized test fails.</comment>
<file context>
@@ -0,0 +1,41 @@
[email protected]("attrs,snapshot,expected", [
+ ({'inert': ''}, DummySnapshotNode(10, 10, 100, 20), False),
+ ({'aria-hidden': 'true'}, DummySnapshotNode(10, 10, 100, 20), False),
+ ({}, DummySnapshotNode(-10, 10, 100, 20), False),
+ ({}, DummySnapshotNode(10, 10, 0, 20), False),
+ ({}, DummySnapshotNode(10, 10, 100, 0), False),
</file context>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Agents were clicking invisible duplicated slides from nuka-carousel when wrapAround=true,
because cloned elements marked with
inert="true"andaria-hidden="true"were stillbeing detected as interactive. This caused invalid click coordinates and missed actions.
Added visibility filtering to skip elements that are inert, aria-hidden, have zero size,
or are positioned off-screen before interaction.
Summary by cubic
Stops clicks on cloned, hidden slides in carousels (e.g., nuka-carousel with wrapAround) by filtering inert, aria-hidden, zero-size, and fully offscreen elements from clickable detection. Ensures agents click only visible, valid targets.