Thanks to visit codestin.com
Credit goes to github.com

Skip to content

pr-3564 #3586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

pr-3564 #3586

wants to merge 2 commits into from
+26 −0

Conversation

@MagMueller
Copy link
Collaborator

@MagMueller MagMueller commented Nov 14, 2025 •
edited by cubic-dev-ai bot
Loading

Auto-generated PR for branch: pr-3564

Note

Introduce is_inert propagation (via inert and aria-hidden) during DOM tree construction and skip inert elements in clickable detection.

  • DOM Model:
    • Add is_inert boolean to EnhancedDOMTreeNode in browser_use/dom/views.py for O(1) inert lookup.
  • Tree Construction (browser_use/dom/service.py):
    • Compute and propagate is_inert from ancestors; set when element has inert or aria-hidden truthy.
    • Preserve existing iframe/scroll handling; add debug logging around HTML frame scroll.
  • Clickable Detection (browser_use/dom/serializer/clickable_elements.py):
    • Skip nodes with is_inert before other interactivity checks.
    • Keep large iframe handling unchanged (interactive if >100x100).

Written by Cursor Bugbot for commit 7a7b099. This will update automatically on new commits. Configure here.

Summary by cubic

Skip inert and aria-hidden elements when detecting interactive DOM nodes. This prevents clicks on hidden or disabled UI and makes checks O(1) via a precomputed flag.

  • Bug Fixes
    • Compute and propagate is_inert during tree build (from inert or aria-hidden='true/1', inherited from parent).
    • is_interactive now ignores nodes with is_inert.

Written for commit 7a7b099. Summary will update automatically on new commits.

@github-actions
Copy link

github-actions bot commented Nov 14, 2025

Agent Task Evaluation Results: 2/2 (100%)

View detailed results
Task Result Reason
amazon_laptop ✅ Pass Skipped - API key not available (fork PR or missing secret)
browser_use_pip ✅ Pass Skipped - API key not available (fork PR or missing secret)

Check the evaluate-tasks job for detailed task execution logs.

@MagMueller
Copy link
Collaborator Author

MagMueller commented Nov 14, 2025

Evaluation Results

Commit: 7a7b099 • Score: ✅ 99.9%

📊 View Details

Summary

  • Success Rate: ✅ 99.9%
  • Average Steps: 5.4 steps/task
  • Average Time: 9.2 sec/task
  • Average Time per Step: 1.7s/step

Automated evaluation by browser-use

cubic-dev-ai[bot]
cubic-dev-ai bot reviewed Nov 14, 2025
View reviewed changes
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cubic-dev-ai cubic-dev-ai[bot] cubic-dev-ai[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MagMueller @PredictiveManish