fix: implemented saving modal instead of discarding #25156
+25
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Pallava-Joshi is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details: |
Udit-takkar
reviewed
Nov 14, 2025
Comment on lines
+43
to
+50
| const hasStructuralFieldChanges = () => { | ||
| const saved = form.fields ?? []; | ||
| const current = formContext.getValues("fields") ?? []; | ||
| if (saved.length !== current.length) return true; | ||
| for (let i = 0; i < saved.length; i++) { | ||
| if (saved[i]?.id !== current[i]?.id) return true; | ||
| } | ||
| return false; |
Contributor
There was a problem hiding this comment.
what does structural field change mean?
Udit-takkar
reviewed
Nov 14, 2025
| return false; | ||
| }; | ||
|
|
||
| const hasUnsaved = formContext.formState.isDirty || hasStructuralFieldChanges(); |
Contributor
There was a problem hiding this comment.
If possible we should try to just use formContext.formState.isDirty here. We also using isDirty pattern everywhere in our codebase. If something in form has been changed then isDirty must be true.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #25155
Screen.Recording.2025-11-14.at.2.58.03.PM.mov
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Summary by cubic
Adds a save-confirmation modal when leaving the Routing Form editor for Route Builder, so unsaved changes are preserved instead of discarded.
Written for commit d2a8956. Summary will update automatically on new commits.