fix: improve booking list stability by preventing unmount/remount on re-renders #25165
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR improves the stability of booking list items by preventing unnecessary unmount/remount cycles during re-renders, which was causing (avatar) flickering in the UI.
Changes:
confirmMutation.mutateto a stable reference to prevent thehandleAcceptcallback from being recreated on every rendergetRowIdfunction to the table configuration to provide stable row identifiers, preventing React Table from unmounting and remounting rows unnecessarilyVisual Demo
No visual demo provided - this fix addresses flickering that occurs during booking list updates (e.g., when accepting/rejecting bookings).
Mandatory Tasks
How should this be tested?
Key areas to verify:
Human Review Checklist
Please pay special attention to:
getRowIdfunction handles all possible row types (currently handles "data" and "separator" types)confirmMutation.mutatedoesn't cause stale closure issues or break tRPC mutation behavior[confirmMutation]to[confirmMutationMutate]in thehandleAcceptcallback is correctLink to Devin run: https://app.devin.ai/sessions/1987c587ca07434a8025f85eded434da
Requested by: [email protected] (@eunjae-lee)