Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove jobmanager platform provider and integration tests #653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Remove jobmanager platform provider and integration tests #653

wants to merge 14 commits into from
+43 −10,203

Conversation

Copy link

Copilot AI commented Nov 12, 2025 •
edited
Loading

Remove jobmanager platform and related integration tests

This PR removes the jobmanager platform/provider implementation and related integration tests as they are no longer used and not part of any public API.

Changes Made

  • Removed jobmanager integration tests and unit tests
  • Removed jobmanager_provider, jobmanager_api, and JobManagerConfiguration
  • Updated Platform enum to only include GITHUB
  • Simplified platform_factory to only accept GitHub configuration
  • Updated reactive consumer to reject non-GitHub URLs
  • Removed jobmanager from dependencies and configuration files
  • Bumped application version to 0.7.0
  • Improved code quality: Reversed check order in platform_factory for cleaner logic flow

Follow-up Work Identified

Based on code review, the following cleanup opportunities have been identified for future PRs:

  • Remove Platform enum (single value no longer needed)
  • Simplify or remove platform_factory (only one implementation)
  • Analyze and potentially simplify RunnerMetadata usage
  • Remove PlatformProvider abstraction layer

Testing

  • All unit tests pass
  • Static analysis passes
  • Security scan passes (CodeQL - 0 alerts)

Checklist

  • Create inventory of all affected files
  • Remove jobmanager integration tests
  • Update CI workflow
  • Remove jobmanager implementation
  • Update unit tests
  • Run tests - PASSED ✓
  • Update CHANGELOG
  • Bump application version to 0.7.0
  • Code review improvements applied
Original prompt

This section details on the original issue you should resolve

<issue_title>Remove jobmanager platform and related integration tests</issue_title>
<issue_description>Background

The jobmanager platform is no longer used and is not part of any public API. Removing it will reduce maintenance and simplify the test matrix for this repository.

Scope

  • Remove the jobmanager platform/provider implementation (jobmanager_provider).
  • Remove the two integration tests: test_jobmanager_prespawned and test_jobmanager_reactive.
  • Update CI (GitHub Actions), documentation, and related build configuration accordingly.

Checklist

  • Search the repo for jobmanager, jobmanager_provider, test_jobmanager_prespawned, and test_jobmanager_reactive, and produce an inventory of affected files.
  • Remove or skip the two integration test modules and confirm CI is green.
  • Remove jobmanager_provider and all code/config references to the jobmanager platform.
  • Remove jobmanager-related docs, examples, and manifests.
  • Update CI workflows/build files to remove jobmanager from the test matrix.
  • Run full unit and integration tests for remaining platforms, fix any unrelated regressions discovered.
  • Update README and architecture docs, and add a CHANGELOG entry describing this removal.

Branch suggestion: remove/jobmanager-and-tests
Labels: cleanup, refactor
Effort: 1–3 PRs, 4–12 hours depending on cross-repo impacts.

Additional context: This issue initiates complete removal since jobmanager is not exposed as any public API to consumers.
</issue_description>

Comments on the Issue (you are @copilot in this section)

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI changed the title [WIP] Remove jobmanager platform and related integration tests Remove jobmanager platform provider and integration tests Nov 12, 2025
Copilot AI requested a review from cbartz November 12, 2025 09:28
Copilot finished work on behalf of cbartz November 12, 2025 09:28
cbartz
cbartz approved these changes Nov 12, 2025
View reviewed changes
Copy link
Collaborator

@cbartz cbartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cbartz cbartz marked this pull request as ready for review November 12, 2025 09:40
@cbartz
Copy link
Collaborator

cbartz commented Nov 13, 2025

@copilot can you bump the application version number ?

Copy link
Author

Copilot AI commented Nov 13, 2025

@copilot can you bump the application version number ?

Bumped application version from 0.6.3 to 0.7.0 in commit a405175.

Copilot AI requested a review from cbartz November 13, 2025 06:38
Copilot finished work on behalf of cbartz November 13, 2025 06:38
yanksyoon
yanksyoon reviewed Nov 17, 2025
View reviewed changes
Copy link
Member

@yanksyoon yanksyoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot please follow up on this preliminary review.

Copilot AI requested a review from yanksyoon November 17, 2025 06:41
Copilot finished work on behalf of yanksyoon November 17, 2025 06:41
Copilot finished work on behalf of yanksyoon November 17, 2025 06:46
Copilot finished work on behalf of yanksyoon November 17, 2025 06:49
Copilot finished work on behalf of yanksyoon November 17, 2025 07:20
yanksyoon
yanksyoon approved these changes Nov 17, 2025
View reviewed changes
Copy link
Member

@yanksyoon yanksyoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot Good bot! Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@weiiwang01 weiiwang01 weiiwang01 approved these changes

@yanksyoon yanksyoon yanksyoon approved these changes

@yhaliaw yhaliaw yhaliaw approved these changes

@javierdelapuente javierdelapuente Awaiting requested review from javierdelapuente javierdelapuente is a code owner

+1 more reviewer

@cbartz cbartz cbartz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@cbartz cbartz

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove jobmanager platform and related integration tests

5 participants

@cbartz @weiiwang01 @yanksyoon @yhaliaw