chore(spec.md): Remove YAML 1.1 concern for port syntax #491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Technically a valid concern if the YAML parser is not 1.2 compliant (published 2009Q3) which dropped this number format.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
YAML 1.2 (published 2009Q3) dropped this number format. Technically still a valid concern if the YAML parser is not 1.2 compliant (third-party implementations?).
I covered history and details in a related PR: docker-mailserver/docker-mailserver#3982
Which issue(s) this PR fixes
I just noticed that this was added to the spec in Jan 2020 with many other changes and no context available. This was an issue with the Python version of Docker Compose AFAIK, but is intentionally avoided with the YAML parser package used in the Go rewrite.
As far as quoting goes, that should only be relevant for ports 0-59 when the YAML parser is not YAML 1.2 compliant?
Feel free to reject 👍 (if otherwise wanting to merge, let me know and I'll sort out that DCO check)