Fix temperature normalization for gpt-5 search models #502
+11
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Models like gpt-5-search-api were incorrectly matching the gpt-5 pattern and getting temperature=1.0, when they should match the -search pattern and get nil.
Reordered conditions to check for -search models first, ensuring the more specific pattern takes precedence.
What this does
Fixes a bug in
normalize_temperaturewhere the condition order caused search models in the GPT-5 family (e.g.,gpt-5-search-api) to incorrectly receivetemperature=1.0instead ofnil.The fix reorders the pattern matching so the more specific
-searchcheck happens before the broadergpt-5check, ensuring search models don't accept the temperature parameter as required by the OpenAI API.Type of change
Scope check
Quality check
overcommit --installandbundle exec rake vcr:record[provider_name]bundle exec rspecmodels.json,aliases.json)API changes