Thanks to visit codestin.com
Credit goes to github.com

Skip to content

tests/data: more XML-compliance via %LT and %GT macros in email addresses #19470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

tests/data: more XML-compliance via %LT and %GT macros in email addresses #19470

wants to merge 6 commits into from
+195 −193

Conversation

@vszakats
Copy link
Member

@vszakats vszakats commented Nov 11, 2025 •
edited
Loading

Reduce number of files failing xmllint --format from 133 to 57
(3% of 1894), by replacing < and > with new macro %LT and %GT,
in most places, which is in email addresses.

Follow-up to a9ec2a6 #19491

WIP: with further %LT, %GT replacements and adding %AMP
(93 uses in 68 lines), it's down to 2 files.

  • also macrofy the unbracketet email addresses.
  • backtrack to only macrofy @.
  • think how to pass a filename attr with " in it without breaking XML parsers. (affected: 1158, 1186) [MAYBE NEXT TIME]
  • some annoying bits: [DROPPED these from this patch]

@vszakats vszakats marked this pull request as draft November 11, 2025 19:41
@github-actions github-actions bot added the tests label Nov 11, 2025
@vszakats vszakats changed the title tests/data: try making more of them XML-compliant tests/data: try making more files XML-compliant Nov 11, 2025
@vszakats vszakats mentioned this pull request Nov 11, 2025
Merged
@vszakats vszakats changed the title tests/data: try making more files XML-compliant tests/data: make more files XML-compliant Nov 12, 2025
@vszakats vszakats marked this pull request as ready for review November 12, 2025 00:11
@vszakats vszakats marked this pull request as draft November 12, 2025 00:33
@vszakats vszakats changed the title tests/data: make more files XML-compliant tests/data: improve XML-compliance by using %LT and %GT macros Nov 12, 2025
@vszakats vszakats marked this pull request as ready for review November 12, 2025 13:47
@vszakats

This comment was marked as resolved.

Sign in to view
@vszakats vszakats mentioned this pull request Nov 12, 2025
Closed
@vszakats vszakats mentioned this pull request Nov 13, 2025
Closed
vszakats added a commit that referenced this pull request Nov 13, 2025
@vszakats
tests/data: add %includetext, dedupe XML payloads into external file
ca27404 
To reduce duplication and to avoid keeping XML-like markup within XML
markup (`test*`), that was tripping `xmllint`.

Ref: #19470

Closes #19504
@vszakats vszakats changed the title tests/data: improve XML-compliance by using %LT and %GT macros tests/data: more XML-compliance by using %LT and %GT macros in email addresses Nov 13, 2025
@vszakats
Copy link
Member Author

vszakats commented Nov 13, 2025 •
edited
Loading

I settled with replacing <> enclosures around email addresses with %LT and %GT.
I think +76 XML-compliant files is a good gain for the <195 modified lines (out of the 120000).

@vszakats vszakats changed the title tests/data: more XML-compliance by using %LT and %GT macros in email addresses tests/data: more XML-compliance via %LT and %GT macros in email addresses Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

tests

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@vszakats