Upgrades Dev Proxy to .NET 10. Closes #1445 #1449
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades Dev Proxy from .NET 9.0 to .NET 10.0, updating all project files, build scripts, and package lock files accordingly. Additionally, it implements logging performance optimizations using IsEnabled checks and adopts C# field keyword feature in the DevProxyCommand class.
Key changes:
- Updated target framework from
net9.0tonet10.0across all projects - Added
Logger.IsEnabled(LogLevel)checks before logging calls throughout the codebase - Adopted C#
fieldkeyword inDevProxyCommandproperty accessor - Removed redundant package dependencies that are now implicitly included in .NET 10
Reviewed Changes
Copilot reviewed 43 out of 43 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| DevProxy/DevProxy.csproj | Updated TargetFramework to net10.0, removed explicit Microsoft.Extensions.* package references |
| DevProxy.Plugins/DevProxy.Plugins.csproj | Updated TargetFramework to net10.0 |
| DevProxy.Abstractions/DevProxy.Abstractions.csproj | Updated TargetFramework to net10.0 |
| scripts/local-build.ps1 | Updated build output path from net9.0 to net10.0 |
| .vscode/launch.json | Updated debug paths from net9.0 to net10.0 |
| .github/workflows/create-release.yml | Updated release paths from net9.0 to net10.0 |
| DevProxy/Commands/DevProxyCommand.cs | Replaced backing field with C# field keyword in property getter |
| DevProxy/Proxy/ProxyEngine.cs | Added IsEnabled check before debug logging |
| Multiple plugin files | Added IsEnabled checks before logging calls for performance |
| DevProxy.Plugins/Generation/HarGeneratorPlugin.cs | Removed null-forgiving operator from key variable |
| DevProxy.Abstractions/Models/MockResponse.cs | Added ArgumentNullException.ThrowIfNull check for logger parameter |
| .editorconfig | Added CA1873 diagnostic suppression |
| packages.lock.json files | Updated dependency tree for .NET 10.0 compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades Dev Proxy to .NET 10. Closes #1445