fix: file extension changing to canonical form due to mac UTType #48412
+122
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ction (cherry picked from commit bfa90feb02c97a123a7a2c407c0f069d66f5e0ad)
Author
|
@codebytere please let me know if I handled something incorrectly. |
Member
|
@0biwan-ops Please add release notes to your PR description |
Author
|
@mlaurencin could run the tests again to check if anything is failing |
cucbin
reviewed
Nov 12, 2025
|
|
||
| [[self savePanel] setAllowedContentTypes:allowAllFiles ? @[] : content_types]; | ||
| #pragma clang diagnostic push | ||
| #pragma clang diagnostic ignored "-Wdeprecated-declarations" |
Contributor
There was a problem hiding this comment.
It is advisable to avoid the use of the deprecated API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This code stores the provided extension and then gets the UTType for the filenameextension and then compares it with the provided type and then uses the provided one if the canonical refers to the same extension type.
Example:
.hpphas the canonical type as.hhbut the code compares the two's UTType and then uses.hppif the UTType was identified and is same for canonical and this.Closes #48332
Checklist
npm testpassesRelease Notes
Notes: none