fix: abort more descriptively for beforeunload #48960
Open
+46
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepak1556
reviewed
Nov 16, 2025
Member
deepak1556
left a comment
There was a problem hiding this comment.
LGTM, pending windows test needing path fixes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #48912
Tracks the target of a pending navigation during beforeunload and, if the unload isn’t prevented, aborts the next load with a descriptive did-fail-load (ERR_ABORTED) instead of letting it fail generically. Also improves docs to point to
will-prevent-unloadbehavior aroundloadURL.Checklist
npm testpassesRelease Notes
Notes: none