better plot scaling logic #938
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@almarklein getting large diffs with colors across the entire canvas, did something change recently? Regenerate is producing nans for some images so I'm guessing the image saving lib change something recently: https://github.com/fastplotlib/fastplotlib/actions/runs/19291516914/job/55163104901?pr=938#step:8:1528 
|
Collaborator
|
Could you try pinning |
Collaborator
|
But still, it also happens for |
Member
Author
|
📚 Docs preview built and uploaded! https://www.fastplotlib.org/ver/better-plot-scaling |
Member
Author
|
@clewis7 gtg! |
clewis7
approved these changes
Nov 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When one controller manages multiple cameras in a Figure, i.e. when multiple subplot all share a controller, the current implementation of
auto_center()andauto_scale()sets the cameras of those other subplots based on the bounding box of the scene in the current subplot. This is a problem when the scales are very different between subplots!This PR now sets the cameras of the other subplots based on the other subplot's own scene bbox.
closes #783 , closes #821
Example with the same code from #783
Notice how the y-scales are very different.
sync.x-2025-11-12_03.18.14.mp4
@clewis7 can we get this merged ASAP please 😄
This shouldn't break any existing functionality, the screenshot tests will tell.