fix the es httpUser & httpPassword #1775
Open
+22
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chengwei Guo <[email protected]>
marcofranssen
requested changes
Nov 14, 2025
Collaborator
marcofranssen
left a comment
There was a problem hiding this comment.
This seems wrong. Isn't the httpUser and httpPassword just a string?
Maybe we should also update the values.yaml file to better document that part.
Collaborator
Author
Signed-off-by: Chengwei Guo <[email protected]>
Collaborator
Can we update, values.yaml to reflect this structure? |
| {{- end }} | ||
| {{- with .Values.fluentbit.output.es.httpUser }} | ||
| httpUser: {{ . | quote }} | ||
| httpUser: {{ toYaml . | nindent 6 }} |
Collaborator
There was a problem hiding this comment.
Suggested change
| httpUser: {{ toYaml . | nindent 6 }} | |
| httpUser: | |
| {{- toYaml . | nindent 6 }} |
| {{- end }} | ||
| {{- with .Values.fluentbit.output.es.httpPassword }} | ||
| httpPassword: {{ . | quote }} | ||
| httpPassword: {{ toYaml . | nindent 6 }} |
Collaborator
There was a problem hiding this comment.
Suggested change
| httpPassword: {{ toYaml . | nindent 6 }} | |
| httpPassword: | |
| {{- toYaml . | nindent 6 }} |
Signed-off-by: Chengwei Guo <[email protected]>
| # index: "fluent-bit" | ||
| # httpUser: | ||
| # httpPassword: | ||
| # logstashPrefixKey: ks-logstash-log |
Collaborator
There was a problem hiding this comment.
Suggested change
| # logstashPrefixKey: ks-logstash-log |
Already shows as uncommented at line 305
| # logstashPrefixKey: ks-logstash-log | ||
| # suppressTypeName: "On" | ||
| # path: "" | ||
| # bufferSize: "4KB" |
Collaborator
There was a problem hiding this comment.
Suggested change
| # bufferSize: "4KB" |
Already shows as uncommented on line 306
| # index: "fluent-bit" | ||
| # httpUser: | ||
| # httpPassword: | ||
| # logstashPrefixKey: ks-logstash-log |
Collaborator
There was a problem hiding this comment.
Looks like indentation of the entire comment block is of.
Would be great if soeone uses the IDE shortcut for uncommenting all indentation of the entire commented block is correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fix the es template introduced in #1555
Which issue(s) this PR fixes:
Fixes #1674
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.: