Thanks to visit codestin.com
Credit goes to github.com

Skip to content

False positive: Dereferenced variable may be null ignore NRT attributes #20828

@Euan-McVie

Description

@Euan-McVie

Description of the false positive

NRT attributes appear to be ignored by CodeQL. This results in lots of noise as we have to explicitly mark each point of use as a false positive and so safe.

Code samples or links to source code

      if (TryConvertContractState(tradingPhase, state, out Models.ContractState? contractState))
            return contractState.Value;

when it is defined as:

    private static bool TryConvertContractState(
        string tradingPhase, string state,
        [NotNullWhen(true)] out PersistedModels.ContractState? cdmState)
    {}

URL to the alert on GitHub code scanning (optional)

Private Repo, but the view query source goes to: https://github.com/github/codeql/blob/aa3000df1310b332ba1c84afec3bacb0aeb4dbbd/csharp/ql/src/CSI/NullMaybe.ql

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions