1. When creating a new file, it currently redirects to the classic “new file” page. Instead, it should open an inline editor similar to GitHub’s implementation, keeping the left tree view visible. The same behavior should apply to Upload Files and Apply Patch actions.
2. There is no way to add a new file for the root directory in the tree view UI.

2. There is no way to add a new file for the root directory in the tree view UI.

You can do so in the main repo page in the code tab, same as to how its done on Github. Since I'm not aware of a way to view the root directory except for in the main repo page on the code tab (same on Github). Or perhaps I'm not understanding what you mean.

1. When creating a new file, it currently redirects to the classic “new file” page. Instead, it should open an inline editor similar to GitHub’s implementation, keeping the left tree view visible. The same behavior should apply to Upload Files and Apply Patch actions.

Added

• It seems there is a bug that the icon to show/hide tree view will always be hidden.

• And maybe the commit box should be move to up right corner like what github did after the tree view introduced to the editor page.

• It seems there is a bug that the icon to show/hide tree view will always be hidden.

Fixed

• And maybe the commit box should be move to up right corner like what github did after the tree view introduced to the editor page.

Moved. Should be more like Github's UX now:

Great work!

• It seems the Delete File UI needs some improvements? The close button in the top-right corner doesn’t seem to work either. Perhaps converting this into a popup dialog would provide a better experience than open in a new page.

• The Apply Patch UI seems to need some improvements. There are two “Cancel” buttons and the repository name appears twice. I don’t think this issue is caused by this PR, but since it’s related, it would be better to address them together.

• Creating a new file under the root folder is inconvenient because I have to return to the repository’s home page each time. I understand this behavior is inherited from GitHub, but it doesn’t seem like the best design. Could you also add buttons for Create File / Upload File / Apply Patch directly in the file view, so that new items can be created under the same folder as the currently viewed file?

Ok, attempting the changes requested but concerned that PR is starting to go beyond scope.

• It seems the Delete File UI needs some improvements? The close button in the top-right corner doesn’t seem to work either. Perhaps converting this into a popup dialog would provide a better experience than open in a new page.

Moved to popup modal

• The Apply Patch UI seems to need some improvements. There are two “Cancel” buttons and the repository name appears twice. I don’t think this issue is caused by this PR, but since it’s related, it would be better to address them together.

• Creating a new file under the root folder is inconvenient because I have to return to the repository’s home page each time. I understand this behavior is inherited from GitHub, but it doesn’t seem like the best design. Could you also add buttons for Create File / Upload File / Apply Patch directly in the file view, so that new items can be created under the same folder as the currently viewed file?

Added

Ok, attempting the changes requested but concerned that PR is starting to go beyond scope.

Sorry, I didn’t fully consider how the commit model would look after the change—it does become a bit awkward. I also noticed that deleting a file opens a popup window, but deleting a directory still redirects to a separate page. Could we update the delete directory action to use the same popup window approach for consistency?

I think this should be the last feature request from me (though I still need to review the code).

Sorry, I didn’t fully consider how the commit model would look after the change—it does become a bit awkward. I also noticed that deleting a file opens a popup window, but deleting a directory still redirects to a separate page. Could we update the delete directory action to use the same popup window approach for consistency?

No, it shouldn't use a modal unless you can make the code/logic exactly the same as that page. The "deleting modal" in this PR is also incomplete.

If you are not able to provide a feasible solution, just redirect all to the existing pages, but not keep adding unmaintainable "modals"

Getting conflicting feedback, should I proceed with the modals or not? Maybe the modals are proving to be problematic? @lunny

The "deleting modal" in this PR is also incomplete.

Can I get clarification on which part is incomplete. @wxiaoguang

Getting conflicting feedback, should I proceed with the modals or not? Maybe the modals are proving to be problematic? @lunny

The "deleting modal" in this PR is also incomplete.

Can I get clarification on which part is incomplete. @wxiaoguang

It appears that GitHub redirects to a dedicated page with a left-side tree view and a complete list of files that will be deleted. In that case, please disregard my earlier request to move it to a popup dialog.

Getting conflicting feedback, should I proceed with the modals or not? Maybe the modals are proving to be problematic? @lunny

You need to do your best to understand the problem and figure out what's the right thing to do, but not just follow the reviewer's suggestions that can be wrong.

The "deleting modal" in this PR is also incomplete.

Can I get clarification on which part is incomplete. @wxiaoguang

Many, you can read the code to see more details, for example: fork-on-edit (why the form uses "TargetFormAction" but not the current one?), commit-email-selector (why there is "CommitCandidateEmails" and how it works?), etc. Blindly copying-pasting existing code only causes problems.

Personally, I think switching to the modals for the commit form may have been an unnecessary change in this PR. They introduced complexity and I agree that the look is kind of awkward. Personally I think the existing approach was already a pretty solid solution. To switch to the modal approach needs more consideration both in design and implementation, which can be done in a separate issue.

If we can roll back on the modal approach and no longer add feature requests, I can clean up the code better and wind this PR up. What do you think @lunny ?