wgsl: support swizzle assignment #5268
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fe9ba88 to
d7c5282
Compare
Contributor
|
Previews, as seen when this build job started (f17717e): |
d7c5282 to
c984105
Compare
abeafa1 to
9aa6e7f
Compare
Contributor
GPU Web WG 2025-07-30 Atlantic-time
|
Add language extension 'swizzle_assignment' Example: var v:vec4u; v.yz = vec2(1,2); Issue: gpuweb#737
9aa6e7f to
f17717e
Compare
dj2
reviewed
Oct 2, 2025
| 3. Evaluate |e2|. | ||
|
|
||
| 4. Compute |update| by performing the specified binary operation on |viewed_contents| and |e2|. | ||
| * For example, if the swizzle assignment is `v += w` then the specified operation is addition. |
Member
There was a problem hiding this comment.
This isn't actually a swizzle assignment. Should this be v.wx += w to make clearer it's a swizzle assign?
dneto0
commented
Oct 24, 2025
Contributor
Author
dneto0
left a comment
There was a problem hiding this comment.
There is an interaction with 15.2.5 Function Scope Variable Value Analysis, where a swizzle view should sometimes be considered a full reference. It would be if the root variable is of vector type, because a swizzle assignment is deemed to be overwriting the entire vector.
Contributor
|
@dneto0 I gather that, since this is a draft, it's not ready for committee discussion? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add language extension 'swizzle_assignment'
Example:
var v:vec4u;
v.yz = vec2(1,2);
Issue: #737