Move handleEvent to WebSocketEventHandler #6051
Draft
+224
−125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For readability reasaon the handleEvent fucntion has been moved WebSocketCoreImpl to WebSocketEventHandler. The function could be refactored into smaller functions later on. Test still need to be added.
There was a problem hiding this comment.
ktlint found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Member
|
@NeimadTL thanks for your contributions, I'm going to put this PR in draft since you have some ktlint issues. I would also like to see unit tests like it is written in the issue you've linked. |
Author
|
@NeimadTL , you're welcome. Indeed, I still have some work to do on it (linter + tests, maybe some more refactoring); will continue soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For readability reason the handleEvent function has been moved
WebSocketCoreImpltoWebSocketEventHandler. The function could be refactored into smaller functions later on. Tests still need to be added.Related to #5271