-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Hide shortcuts for a mobile client #27905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
|
I'm confused. These are already hidden on mobile |
|
Oops. I see them in Chrome with a mobile agent. |
|
Oh, yeah, I was looking at the tips only. Not sure about hiding the Shortcuts button. It's already quite hidden so I see no harm in leaving it there. |
Some people are rather demanding and may start asking "what shortcuts? I have no shortcuts". |
|
I think it's a detail that is may not necessary but totally fine to implement. Now its implemented let's hide it. |
|
Please remove the tooltip change if it is not needed so we don't have redundant code. Also UX team agreed that the Shortcuts button doesn't need to be hidden. It's not in the way and you can in theory connect a keyboard to a mobile device. |
|
Ok, will edit the PR when be near a PC. Thanks a lot for helping!! |


Breaking change
Proposed change
Similar to #25020
Hiding shortcut suffixes for menu items, tip in a Quick bar & "Shortcuts" button.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: