-
Notifications
You must be signed in to change notification settings - Fork 8.2k
krt: migrate config store controllers to krt #58287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Skipping CI for Draft Pull Request. |
a53abe5 to
2264bc0
Compare
ccaccdf to
226a0c0
Compare
5637752 to
d9ce8f7
Compare
|
@howardjohn could you take a look at this please? |
d9ce8f7 to
d756079
Compare
d756079 to
03a62bd
Compare
|
@sschepens: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/restest |
Please provide a description of this PR:
This PR moves all remaining
ConfigStoreControllerimplementations to using KRT and adds aKrtCollectionmethod toConfigStoreControllerto allow retreiving underlying KRT collections from the controllers and to ensure all controllers are really KRT-based.This should ease construction of additionaly KRT layers on top of current ConfigStoreControllers or eventually ease moving into a KRT Index such as ambient.
Controllers affeced:
GetandList, this allows testing that all other Controller's KRT collections work correctly. removed internalnamespacesFilterit was unused.Runis called, this allows most of our test cases to continue to work without major changes.config.Configinstead of*config.Configto be more compatible withConfigStoreControllersand it also allows us not to transform the returned values from the collections.memory.Controller.