Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[release-1.28] fix: Fix collisions in shared name cross-namespace #58300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: release-1.28
Choose a base branch
from
Open

[release-1.28] fix: Fix collisions in shared name cross-namespace #58300

wants to merge 1 commit into from
+426 −1

Conversation

@istio-testing
Copy link
Collaborator

@istio-testing istio-testing commented Nov 14, 2025

This is an automated cherry-pick of #58299

@zabhi @istio-testing
fix: Fix collisions in shared name cross-namespace
49dee6d 
When ListenerSets with the same name in different namespaces used the same listener name (e.g., http), they generated Istio Gateway configs with identical names, causing a collision where one overwrites the other.

Also added a regression test case that fails without the fix and regenerated golden files.
@istio-testing istio-testing requested a review from a team as a code owner November 14, 2025 17:11
@istio-testing istio-testing added the release-notes-none Indicates a PR that does not require release notes. label Nov 14, 2025
@istio-testing istio-testing mentioned this pull request Nov 14, 2025
Merged
@istio-testing istio-testing added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 14, 2025
@istio-testing
Copy link
Collaborator Author

istio-testing commented Nov 14, 2025

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
gencheck_istio_release-1.28 49dee6d link true /test gencheck
unit-tests-arm64_istio_release-1.28 49dee6d link true /test unit-tests-arm64
unit-tests_istio_release-1.28 49dee6d link true /test unit-tests
integ-ambient-mc_istio_release-1.28 49dee6d link false /test integ-ambient-mc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@zabhi
Copy link
Contributor

zabhi commented Nov 15, 2025

Can be closed as duplicate of #58304.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

release-notes-none Indicates a PR that does not require release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@istio-testing @zabhi