fix describedby #1344
Open
fix describedby #1344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified: src/validator.js
germanbisurgi
requested changes
Jun 22, 2023
Collaborator
There was a problem hiding this comment.
@Djuvl At line 723 the this.getWatchedFieldValues() method does not exist. If this line is left unchanged then the fix works.
Author
|
Lines 471 to 473 in e89c43d ok, the method is not exist on the validator object. But simply left the old code unchanged is not a good way, as it will always get a undifined. The validator need to get the watched field realtime value, so the value can be pass to the ref template. I did not find a way to get the value in that function. At least the path to the schame is needed, so the watched value can be got from the jsoneditor object, i think. Is there any idea? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modified: src/validator.js src/describedby.js
Fixes #1316