Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@danyaridiger
Copy link
Contributor

@danyaridiger danyaridiger commented May 3, 2024

Q A
Is bugfix?
New feature? ✔️
Is backward-compatible? ✔️
Tests pass? ✔️
Fixed issues
Updated README/docs?
Added CHANGELOG entry?

@danyaridiger
Copy link
Contributor Author

danyaridiger commented May 5, 2024

Looks weird because this PR doesn't affect setValue method, but one of it's method's tests has failed. There are only changes to the event payload. Locally tests run correctly.

@schmunk42
Copy link
Collaborator

@danyaridiger Tests have hick-ups from time to time. I re-ran them and they're passing.

@danyaridiger
Copy link
Contributor Author

Please appoint a reviewer

Copy link
Collaborator

@germanbisurgi germanbisurgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants