Thanks to visit codestin.com
Credit goes to github.com

Skip to content

additioal change #135284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 37 commits into
base: master
Choose a base branch
from
Draft

additioal change #135284

wants to merge 37 commits into from
+2,893 −194

Conversation

@sanposhiho
Copy link
Member

@sanposhiho sanposhiho commented Nov 13, 2025

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR is related to:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

bwsalmon and others added 30 commits November 8, 2025 02:51
@bwsalmon
First version of batching w/out signatures.
0e6f35a
@bwsalmon
First version of pod signatures.
5716eb8
@bwsalmon
Integrate batching with signatures.
818a29c
@bwsalmon
Fix merge conflicts.
964d06f
@bwsalmon
Fixes from self-review.
63c75e1
@bwsalmon
Test fixes.
9571902
@bwsalmon
Fix a bug that limited batches to size 2
1e5bb90 
Also add some new high-level logging and
simplify the pod affinity signature.
@bwsalmon
Re-enable batching on perf tests for now.
466f36f
@bwsalmon
fwk.NewStatus(fwk.Success)
95a07f3
@bwsalmon
Review feedback.
78110f9
@bwsalmon
Review feedback.
5ea2dfe
@bwsalmon
Comment fix.
31d0f37
@bwsalmon
Two plugin specific unit tests.:
ab3b2fc
@bwsalmon
Add cycle state to the sign call, apply to topo spread.
150ed9f 
Also add unit tests for several plugi signature
calls.
@bwsalmon
Review feedback.
b057bed
@bwsalmon
Switch to distinct stats for hint and store calls.
2ddd04d
@bwsalmon
Switch signature from string to []byte
6537cd9
@bwsalmon
Revert cyclestate in signs. Update node affinity.
c8d3d8c 
Node affinity now sorts all of the various
nested arrays in the structure. CycleState no
longer in signature; revert to signing fewer
cases for pod spread.
@bwsalmon
hack/update-vendor.sh
fde9744
@bwsalmon
Disable signatures when extenders are configured.
bfabd8b
@bwsalmon @macsko
Update pkg/scheduler/framework/runtime/batch.go
cf1c124 
Co-authored-by: Maciej Skoczeń <[email protected]>
@bwsalmon @macsko
Update staging/src/k8s.io/kube-scheduler/framework/interface.go
66aea8f 
Co-authored-by: Maciej Skoczeń <[email protected]>
@bwsalmon
Review feedback.
61be224
@bwsalmon
Disable node resource signatures when extended DRA enabled.
4e2890d
@bwsalmon
Review feedback.
fa4c1f5
@bwsalmon @macsko
Update pkg/scheduler/framework/plugins/imagelocality/image_locality.go
994a285 
Co-authored-by: Maciej Skoczeń <[email protected]>
@bwsalmon @macsko
Update pkg/scheduler/framework/interface.go
2d2bddb 
Co-authored-by: Maciej Skoczeń <[email protected]>
@bwsalmon @macsko
Update pkg/scheduler/framework/plugins/nodedeclaredfeatures/nodedecla…
73bb4d8 
…redfeatures.go

Co-authored-by: Maciej Skoczeń <[email protected]>
@bwsalmon @macsko
Update pkg/scheduler/framework/runtime/batch.go
ce633ec 
Co-authored-by: Maciej Skoczeń <[email protected]>
@bwsalmon
Review feedback.
95c758d
@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 13, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 13, 2025

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 13, 2025
@k8s-ci-robot k8s-ci-robot requested review from a team, ardaguclu and cofyc November 13, 2025 04:37
@sanposhiho sanposhiho marked this pull request as draft November 13, 2025 04:37
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/dependency Issues or PRs related to dependency changes area/test sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/storage Categorizes an issue or PR as relevant to SIG Storage. labels Nov 13, 2025
@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 13, 2025
@k8s-ci-robot k8s-ci-robot added the wg/device-management Categorizes an issue or PR as relevant to WG Device Management. label Nov 13, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sanposhiho

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ardaguclu ardaguclu Awaiting requested review from ardaguclu

@cofyc cofyc Awaiting requested review from cofyc

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. wg/device-management Categorizes an issue or PR as relevant to WG Device Management.

Projects

Dynamic Resource Allocation
Archived in project
SIG Node CI/Test Board
Status: Triage
SIG Node: code and documentation PRs
Status: Triage
SIG Scheduling
Status: No status

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sanposhiho @k8s-ci-robot @bwsalmon