Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Enable Declarative Validation for Role #135286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Enable Declarative Validation for Role #135286

wants to merge 1 commit into from
+154 −2

Conversation

@ShaanveerS
Copy link

@ShaanveerS ShaanveerS commented Nov 13, 2025

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR enables the Declarative validation for Role

Which issue(s) this PR is related to:

part of #134280

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/blob/master/keps/sig-api-machinery/5073-declarative-validation-with-validation-gen/README.md

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 13, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 13, 2025

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 13, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 13, 2025

Hi @ShaanveerS. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/auth Categorizes an issue or PR as relevant to SIG Auth. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 13, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 13, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ShaanveerS
Once this PR has been reviewed and has the lgtm label, please assign mikedanese for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ShaanveerS
Copy link
Author

ShaanveerS commented Nov 13, 2025

/cc @yongruilin @lalitc375 @aaron-prindle

@itzPranshul
Copy link
Contributor

itzPranshul commented Nov 13, 2025

#134603 (comment)

As stated previously, PRs that enable new infrastructure should also include migrating at least one rule. Could you please include the migration of a single small, representative rule in this PR?

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 13, 2025
@ShaanveerS
Copy link
Author

ShaanveerS commented Nov 13, 2025

@itzPranshul The only remaining required rules for Role live in PolicyRule (verbs, apiGroups, resources, and the NonResourceURLs interactions).
verbs is already being handled in #135028.

apiGroups and resources are conditionally required (only for resource rules or only when NonResourceURLs is empty) and are still marked +optional in the schema.
I've added some DV tests pkg/registry/rbac/role/declarative_validation_test.go in the latest commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

@sttts sttts Awaiting requested review from sttts

@aaron-prindle aaron-prindle Awaiting requested review from aaron-prindle

@lalitc375 lalitc375 Awaiting requested review from lalitc375

@yongruilin yongruilin Awaiting requested review from yongruilin

Assignees

No one assigned

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

SIG Auth
Status: No status

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ShaanveerS @k8s-ci-robot @itzPranshul