Added a 'debug' option that shows or hides debug traces to console #5
Conversation
|
Merge or disregard? Could you comment on the proposed change? |
|
Cool. Could you change index.html back? The |
|
Hey, thanks for the response. How come the src attributes starting with // or / are prefered? Both resources fail to load when testing locally, or am I missing something here? Edit: I've read up on the protocol relative url for including the jquery form the cdn with // and I can change that. But the /src call does not neccesairly make sense - shouldn't it be relative to the file location, i.e. just src? |
|
The requests are likely failing because you're not serving the files up over a local HTTP server, but letting the operating system server them up. (On a Mac, it will use the OS X file: protocol.) The leading slash is just my style preference, and is a gentle reminder to test over HTTP. |
|
I updated the jquery script src to be protocol neutral, but set the typer include relative. Even if you test via HTTP it is a special case where you have the typer src folder in the root of your server. |
…being 'smart' about it. In certain cases it looks better if the whole string is replaced rather than the difference.
Conflicts: src/jquery.typer.js
…olor Conflicts: src/jquery.typer.js test.html
added updated dist files from previous merged commit
…, revamped and expanded test.html
…f explicit version number
On certain string occurances the plugin would send traces to the console log. I added an optional 'debug' parameter which controls, if those console traces are displayed or not and set it to false by default.
Besides not wanting to show a plugin's own development/debug traces in projects I used the plugin in, I noticed that the plugin would happily fill the console with traces. If a tab was open that ran a page with the typer plugin and you'd return to that tab after browsing in another tab, there sometimes would come a slight delay/unresponsiveness caused by the console being filled with hundreds and thousands of traces.
Additionally, I made the file references in test.html relative.