-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
fix: resolve 4 critical bugs across Lambda, StepFunctions, and Firehose #13356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- fix(lambda): make create_alias idempotent for CDK redeployments (localstack#13351) - fix(stepfunctions): enhance InvalidArn error messages with details (localstack#13315) - fix(firehose): implement S3 CompressionFormat support (GZIP/ZIP/Snappy) (localstack#13301) - fix(stepfunctions): enable variable interpolation in TestState API (localstack#13215) All fixes maintain backward compatibility and follow LocalStack conventions. See BUG_FIXES_SUMMARY.md for detailed documentation.
|
I have read the CLA Document and I hereby sign the CLA Ayush3603 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. |
localstack-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to LocalStack! Thanks for raising your first Pull Request and landing in your contributions. Our team will reach out with any reviews or feedbacks that we have shortly. We recommend joining our Slack Community and share your PR on the #community channel to share your contributions with us. Please make sure you are following our contributing guidelines and our Code of Conduct.
- Add executive summary with impact metrics - Include detailed technical architecture for each fix - Add performance comparisons and business value analysis - Include quality metrics and developer experience improvements - Add visual progress bars and professional formatting - Include future enhancements and acknowledgments
|
fix: resolve 4 critical bugs across Lambda, StepFunctions, and Firehose |
…KeyError on MetricStat lookups and return empty result with message
purcell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! Thanks for taking the time to submit these changes. 🚀
As it stands, this PR contains a number of new, irrelevant files that should not be committed to the repository, e.g. the three markdown files and the powershell/bash scripts. Please could you remove those files from the PR?
It would also be helpful to know which steps you followed to verify that the fixes solve the original issues. Without that or tests, it's quite some effort for the team to assess and validate your contribution.
(As a general point of advice, you might consider submitting individual PRs for such fixes, which makes for easier reviews and merge decisions.)
…er; remove misleading FIXME comments
…plementation guidance
All fixes maintain backward compatibility and follow LocalStack conventions. See BUG_FIXES_SUMMARY.md for detailed documentation.
Motivation
Changes
Tests
Related