Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Declarative tests #5861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 30 commits into
base: main
Choose a base branch
from
Draft

Declarative tests #5861

wants to merge 30 commits into from

Conversation

@Mubelotix
Copy link
Contributor

@Mubelotix Mubelotix commented Aug 26, 2025 •
edited
Loading

TODO

  • Implementation
  • Documentation
  • Run tests on the CI
  • Add test for search on movies
  • Add test for API keys
  • Add test for embeddings
  • Add test for filters/filterable attributes

@Mubelotix Mubelotix added the no db change The database didn't change label Aug 26, 2025
dureuill
dureuill reviewed Aug 26, 2025
View reviewed changes
crates/xtask/src/test/versions.rs
}

pub fn get_arch() -> anyhow::Result<&'static str> {
let arch;
Copy link
Contributor

@dureuill dureuill Aug 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

initialize arch in case none of the cfg match

dureuill
dureuill reviewed Aug 26, 2025
View reviewed changes
crates/xtask/Cargo.toml
tracing-trace = { version = "0.1.0", path = "../tracing-trace" }
uuid = { version = "1.17.0", features = ["v7", "serde"] }
similar-asserts = "1.7.0"
chrono = "0.4"
Copy link
Contributor

@dureuill dureuill Aug 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we're more of a time team at meili

dureuill
dureuill reviewed Aug 26, 2025
View reviewed changes
crates/xtask/src/test/workload.rs
#[serde(rename_all = "camelCase")]
pub struct TestWorkload {
pub name: String,
pub initial_version: Version,
Copy link
Contributor

@dureuill dureuill Aug 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allow latest here. Maybe, make the field optional and assume latest if missing 🤔

@dureuill
Copy link
Contributor

dureuill commented Sep 2, 2025 •
edited
Loading

After discussing with @irevoire:

  1. It would be nice to have the option to test the search while the upgrade is ongoing
  2. To avoid making this racy, tamo suggested it would be nice to be able to start the new version of Meilisearch with the --experimental-max-number-of-batched-tasks=0, which acts as a read-only mode.
  3. To implement this, I think we should generalize the upgrade command to a changeBinary command that would allow starting a new binary (from a version, the latest, or at a specified path) with specified flags.
  4. In line with this I feel like the initialVersion should specify a binary instead (again, version, latest or specified path)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dureuill dureuill dureuill left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

no db change The database didn't change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Mubelotix @dureuill