Update the pico-sdk submodule to ensure that all RP2350 board headers explicitly define PICO_RP2350A. #18417
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the pico-sdk submodule from the previous version (commit 9a4113f) to the latest official Raspberry Pi pico-sdk release version 2.2.0 (commit a1438df). Key changes in pico-sdk 2.2.0 include: - SDK 2.2.0 Release - Resolve the abnormal ADC function issue of the Seeed XIAO RP2350 - Runtime improvements and bug fixes - Various stability and performance improvements The update ensures MicroPython has access to the latest hardware support and features provided by the official pico-sdk.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #18417 +/- ##
=======================================
Coverage 98.38% 98.38%
=======================================
Files 171 171
Lines 22294 22294
=======================================
Hits 21933 21933
Misses 361 361 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
… explicitly define PICO_RP2350A This commit updates the pico-sdk submodule to commit c88bd53, which provides critical fixes for RP2350 board header definitions. Key changes in this specific pico-sdk version: - Ensure all RP2350 board-headers explicitly define PICO_RP2350A - Fixes board detection and configuration for RP2350 variants - Improves compatibility with RP2350A and RP2350B chip variants MicroPython v1.26.1 on 2025-09-11; Seeed XIAO RP2350 with RP2350 Use the firmware in this interface XIAO_RP2350 Use the following test code： Using my new compiled firmware： ``` >>> import machine >>> machine.ADC(4).read_u16() 13955 ``` Observed behaviour： ``` >>> import machine >>> machine.ADC(29).read_u16() Traceback (most recent call last): File "<stdin>", line 1, in <module> ValueError: Pin doesn't have ADC capabilities >>> ``` The reason is that pico-sdk is not the latest. The ADC function modified the judgment logic after this submission, and changed the range of the ADC pin to be specified by macro(ADC_BASE_PIN and NUM_ADC_CHANNELS). See: micropython@34e463d These two macros were not used in pico-sdk until after this commit. See: raspberrypi/pico-sdk@c88bd53 The following file is the xiao rp2350 header file in the pico-sdk used by the current version of micropython. This file does not include the changes submitted above. See: https://github.com/raspberrypi/pico-sdk/blob/9a4113fbbae65ee82d8cd6537963bc3d3b14bcca/src/boards/include/boards/seeed_xiao_rp2350.h Please adopt pico-sdk with RP2350A defined in header files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit updates the pico-sdk submodule to commit c88bd53, which
provides critical fixes for RP2350 board header definitions.
Key changes in this specific pico-sdk version:
Testing
MicroPython v1.26.1 on 2025-09-11; Seeed XIAO RP2350 with RP2350
Reproduction：
Use the firmware in this interface XIAO_RP2350
Use the following test code：
Using my new compiled firmware：
Observed behaviour：
Additional Information：
The reason is that pico-sdk is not the latest.
The ADC function modified the judgment logic after this submission, and changed the range of the ADC pin to be specified by macro(ADC_BASE_PIN and NUM_ADC_CHANNELS).
See: 34e463d
These two macros were not used in pico-sdk until after this commit.
See: raspberrypi/pico-sdk@c88bd53
The following file is the xiao rp2350 header file in the pico-sdk used by the current version of micropython. This file does not include the changes submitted above.
See: https://github.com/raspberrypi/pico-sdk/blob/9a4113fbbae65ee82d8cd6537963bc3d3b14bcca/src/boards/include/boards/seeed_xiao_rp2350.h
Please adopt pico-sdk with RP2350A defined in header files
Trade-offs and Alternatives