-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
stress_schedule: Fix for !GIL + emit=native. #18423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #18423 +/- ##
=======================================
Coverage 98.38% 98.38%
=======================================
Files 171 171
Lines 22294 22294
=======================================
Hits 21933 21933
Misses 361 361 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks, but I'm not sure this is the correct fix. Instead, I think (So, this test is revealing a bug in the unix port, that |
|
I can look at it from that angle instead, thanks. |
Locally, this changes the duration of the test from about 2.7s to 0.3s. Signed-off-by: Jeff Epler <[email protected]>
Signed-off-by: Jeff Epler <[email protected]>
Signed-off-by: Jeff Epler <[email protected]>
This test was ignored since 2020, which hid a new bug in the test for the native emitter added in 2024. Hopefully other changes to the test will make it more reliable. Signed-off-by: Jeff Epler <[email protected]>
4b9ee13 to
a74893a
Compare
|
Code size report: |
Summary
When !GIL, the waiter must also be bytecode.
Reduce a wait making the test run 8x faster locally, which hopefully also makes it reliable on ci.
Restore the test during ci.
Closes: #18415
ping @projectgus
Testing
I ran the script manually locally.
Trade-offs and Alternatives
We could delete the test, it's been unused in CI since 2020.