Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@yhmo
Copy link
Collaborator

@yhmo yhmo commented Nov 11, 2025

No description provided.

Signed-off-by: yhmo <[email protected]>
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yhmo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Nov 11, 2025

Codecov Report

❌ Patch coverage is 75.68807% with 53 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (2.5@5065c01). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/impl/types/SearchIteratorImpl.cpp 55.12% 35 Missing ⚠️
src/impl/types/SearchIteratorV2Impl.cpp 89.00% 11 Missing ⚠️
src/impl/types/QueryIteratorImpl.cpp 61.53% 5 Missing ⚠️
src/impl/MilvusClientImpl.cpp 86.66% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff           @@
##             2.5     #363   +/-   ##
======================================
  Coverage       ?   65.79%           
======================================
  Files          ?       67           
  Lines          ?     8166           
  Branches       ?      914           
======================================
  Hits           ?     5373           
  Misses         ?     2700           
  Partials       ?       93           
Files with missing lines Coverage Δ
src/impl/types/QueryResults.cpp 84.21% <100.00%> (ø)
src/impl/types/SearchResults.cpp 83.11% <100.00%> (ø)
src/impl/types/SubSearchRequest.cpp 75.67% <100.00%> (ø)
src/impl/utils/Constants.cpp 100.00% <ø> (ø)
src/impl/utils/GtsDict.cpp 96.77% <100.00%> (ø)
src/impl/utils/GtsDict.h 100.00% <ø> (ø)
src/include/milvus/types/QueryResults.h 100.00% <ø> (ø)
src/include/milvus/types/SearchResults.h 100.00% <ø> (ø)
src/impl/MilvusClientImpl.cpp 79.51% <86.66%> (ø)
src/impl/types/QueryIteratorImpl.cpp 77.55% <61.53%> (ø)
... and 2 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mergify mergify bot added the ci-passed label Nov 11, 2025
@sre-ci-robot sre-ci-robot merged commit 232bef8 into milvus-io:2.5 Nov 11, 2025
11 of 12 checks passed
@yhmo yhmo deleted the 25 branch November 14, 2025 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants