Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@yhmo
Copy link
Collaborator

@yhmo yhmo commented Nov 14, 2025

No description provided.

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yhmo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yhmo yhmo added the lgtm label Nov 14, 2025
@sre-ci-robot sre-ci-robot merged commit dc6b622 into milvus-io:2.5 Nov 14, 2025
10 checks passed
@codecov
Copy link

codecov bot commented Nov 14, 2025

Codecov Report

❌ Patch coverage is 78.76106% with 24 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (2.5@1dc3589). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/impl/types/RunAnalyzerArguments.cpp 68.96% 18 Missing ⚠️
src/impl/types/AnalyzerResults.cpp 50.00% 6 Missing ⚠️

❌ Your patch status has failed because the patch coverage (78.76%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff           @@
##             2.5     #366   +/-   ##
======================================
  Coverage       ?   65.97%           
======================================
  Files          ?       71           
  Lines          ?     8279           
  Branches       ?      918           
======================================
  Hits           ?     5462           
  Misses         ?     2724           
  Partials       ?       93           
Files with missing lines Coverage Δ
src/impl/MilvusClientImpl.cpp 80.13% <100.00%> (ø)
src/impl/MilvusClientImpl.h 91.66% <ø> (ø)
src/impl/MilvusConnection.cpp 87.34% <100.00%> (ø)
src/impl/MilvusConnection.h 92.30% <ø> (ø)
src/include/milvus/MilvusClient.h 100.00% <ø> (ø)
src/include/milvus/types/AnalyzerResults.h 100.00% <100.00%> (ø)
src/include/milvus/types/RunAnalyzerArguments.h 100.00% <100.00%> (ø)
src/impl/types/AnalyzerResults.cpp 50.00% <50.00%> (ø)
src/impl/types/RunAnalyzerArguments.cpp 68.96% <68.96%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants