Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Support RunAnalyzer() #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 14, 2025
Merged

Support RunAnalyzer() #367

merged 1 commit into from
Nov 14, 2025

Conversation

@yhmo
Copy link
Collaborator

@yhmo yhmo commented Nov 14, 2025

No description provided.

@sre-ci-robot
Copy link

sre-ci-robot commented Nov 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yhmo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yhmo yhmo added the lgtm label Nov 14, 2025
@sre-ci-robot sre-ci-robot merged commit 66a55de into milvus-io:master Nov 14, 2025
10 checks passed
@codecov
Copy link

codecov bot commented Nov 14, 2025

Codecov Report

❌ Patch coverage is 78.76106% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.97%. Comparing base (a0592aa) to head (b069bb8).
⚠️ Report is 51 commits behind head on master.

Files with missing lines Patch % Lines
src/impl/types/RunAnalyzerArguments.cpp 68.96% 18 Missing ⚠️
src/impl/types/AnalyzerResults.cpp 50.00% 6 Missing ⚠️

❌ Your patch status has failed because the patch coverage (78.76%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.
❌ Your project status has failed because the head coverage (65.97%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #367       +/-   ##
===========================================
+ Coverage   53.47%   65.97%   +12.49%     
===========================================
  Files          52       71       +19     
  Lines        4432     8279     +3847     
  Branches        0      918      +918     
===========================================
+ Hits         2370     5462     +3092     
- Misses       2062     2724      +662     
- Partials        0       93       +93
Files with missing lines Coverage Δ
src/impl/MilvusClientImpl.cpp 80.13% <100.00%> (-12.22%) ⬇️
src/impl/MilvusClientImpl.h 91.66% <ø> (-8.34%) ⬇️
src/impl/MilvusConnection.cpp 87.34% <100.00%> (+27.18%) ⬆️
src/impl/MilvusConnection.h 92.30% <ø> (-4.36%) ⬇️
src/include/milvus/MilvusClient.h 100.00% <ø> (ø)
src/include/milvus/types/AnalyzerResults.h 100.00% <100.00%> (ø)
src/include/milvus/types/RunAnalyzerArguments.h 100.00% <100.00%> (ø)
src/impl/types/AnalyzerResults.cpp 50.00% <50.00%> (ø)
src/impl/types/RunAnalyzerArguments.cpp 68.96% <68.96%> (ø)

... and 38 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ArkaprabhaChakraborty ArkaprabhaChakraborty Awaiting requested review from ArkaprabhaChakraborty

@xiaofan-luan xiaofan-luan Awaiting requested review from xiaofan-luan

Assignees

No one assigned

Labels

approved ci-passed dco-passed lgtm size/XL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yhmo @sre-ci-robot