feat(go.d): add generic sql collector #21281
Draft
+2,508
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new generic SQL collector module for Netdata that enables monitoring of MySQL, PostgreSQL, and Oracle databases through custom SQL queries. The collector provides a flexible framework for executing arbitrary SQL queries and converting results into Netdata metrics with dynamic chart generation.
Key changes:
- New SQL collector supporting MySQL, PostgreSQL, and Oracle drivers with configurable connection pooling
- Dynamic chart generation based on query results with customizable metadata
- DSN redaction functionality to protect sensitive credentials in logs
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/go/plugin/go.d/collector/sql/collector.go | Main collector implementation with lifecycle methods and default configuration |
| src/go/plugin/go.d/collector/sql/config.go | Configuration structures for database connection, queries, and chart metadata |
| src/go/plugin/go.d/collector/sql/driver.go | Driver imports and supported drivers registry |
| src/go/plugin/go.d/collector/sql/init.go | Configuration validation logic |
| src/go/plugin/go.d/collector/sql/collect.go | Core collection logic, database operations, and DSN redaction utility |
| src/go/plugin/go.d/collector/sql/charts.go | Dynamic chart creation based on query configuration |
| src/go/plugin/go.d/collector/sql/collector_test.go | Tests for DSN redaction functionality |
| src/go/plugin/go.d/collector/init.go | Module registration in the global collector registry |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
@cubic-dev-ai review this PR |
@ktsaou I've started the AI code review. It'll take a few minutes to complete. |
There was a problem hiding this comment.
2 issues found across 9 files
Prompt for AI agents (all 2 issues)
Understand the root cause of the following 2 issues and fix them.
<file name="src/go/plugin/go.d/collector/sql/collect.go">
<violation number="1" location="src/go/plugin/go.d/collector/sql/collect.go:94">
A single parse failure marks this metric as permanently skipped, so later valid values are never collected. Drop or reset the skip flag instead of leaving it true for the lifetime of the collector.</violation>
</file>
<file name="src/go/plugin/go.d/collector/sql/driver.go">
<violation number="1" location="src/go/plugin/go.d/collector/sql/driver.go:14">
The supportedDrivers entry "postgres" does not match the driver name registered by github.com/jackc/pgx/v5/stdlib ("pgx"). A config that passes verifyConfig will still hit sql.Open("postgres", ...) and fail with an unknown driver error. Update the key to the actual driver name or register the alias.</violation>
</file>
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Ask questions if you need clarification on any suggestion
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #13659
Test Plan
Additional Information
For users: How does this change affect me?