Request body: fixed empty body buffering special case. #977
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty request body buffering is specially handled to avoid extra write+seek syscalls as initially introduced in 4c7f511 (0.4.4). This was later broken in chunked body filter in 5fc8543 (1.3.9) where rb->bufs cannot be NULL as it holds at least the final chunk, and further regressed in length body filter in 2a70921 (1.21.2) where rb->bufs started to indicate the last buffer received. The fix is to additionally check if it is the only empty buffer. Found with UndefinedBehaviorSanitizer (pointer-overflow)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Empty request body buffering is specially handled to avoid extra write+seek syscalls as initially introduced in 4c7f511 (0.4.4). This was later broken in chunked body filter in 5fc8543 (1.3.9) where rb->bufs cannot be NULL as it holds at least the final chunk, and further regressed in length body filter in 2a70921 (1.21.2) where rb->bufs started to indicate the last buffer received.
The fix is to additionally check if it is the only empty buffer.
Found with UndefinedBehaviorSanitizer (pointer-overflow)