ENH: add binary exponentiation in polynomial.polyutils._pow
#30150
+6
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polynomial.polyutils._pow
Author
|
I think the checks failed due to decimal value related issues i.e. rounding off, etc. |
Member
|
Once tests are passing, this needs benchmarks to prove it is actually an improvement |
Author
Probably, the tests are failing due to how decimal values are handled by Python(e.g.: 0.33333333333333333*3 is 1.0 in Python). Please look into this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds binary exponentiation to the
_powfunction in 'numpy/polynomial/polyutils.py'Motivation
To optimize exponentiation