MAINT: Enable linting with ruff E501 #28947 (test-numeric.py) #30184
+20
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b863d00 to
046103c
Compare
Jacob-Stevens-Haas
suggested changes
Nov 10, 2025
Contributor
Jacob-Stevens-Haas
left a comment
There was a problem hiding this comment.
Thanks for working on this! A few nits about line breaks to keep relevant things on the same line.
numpy/_core/tests/test_numeric.py
Outdated
| # gh-12130 | ||
| arr_0d = np.array(1) | ||
| ret = np.tensordot(arr_0d, arr_0d, ([], [])) # contracting no axes is well defined | ||
|
|
Contributor
There was a problem hiding this comment.
Delete extra line
Co-authored-by: Jacob Stevens-Haas <[email protected]>
Co-authored-by: Jacob Stevens-Haas <[email protected]>
Co-authored-by: Jacob Stevens-Haas <[email protected]>
Co-authored-by: Jacob Stevens-Haas <[email protected]>
Jacob-Stevens-Haas
approved these changes
Nov 10, 2025
Contributor
Jacob-Stevens-Haas
left a comment
There was a problem hiding this comment.
LGTM! Thanks for working on this!
jorenham
requested changes
Nov 10, 2025
MNT: adding bracketing and linting changes for issue numpy#28947, PR numpy#30184 Co-authored-by: Joren Hammudoglu <[email protected]>
Author
|
@jorenham i've added your suggestions |
jorenham
approved these changes
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#28947
@Jacob-Stevens-Haas