TST: Add F2Py test of building in source directory. #30192
Conversation
f2py failed when the source directory was the build directory, due to a failure to copy the source files to the build directory. This commit accepts this state as resulting in the source files being present in the build directory. Suggested in numpy#29762 and numpy#24874
|
@2sn, applying your suggested fix in the obvious spots did not make the test pass. Was there anything else you did to make this scenario work? |
| ] | ||
| # we filter the only public function mod2 | ||
| only = ["mod1_func1", ] | ||
| options = ["--build-dir", util.get_module_dir()] |
There was a problem hiding this comment.
util.get_module_dir() returns a fresh temporary directory:
numpy/numpy/f2py/tests/util.py
Lines 150 to 157 in 58b1ad7
How is that a test for building inside the source directory?
There was a problem hiding this comment.
util.get_module_dir() also caches that module directory and returns the same one until it's cleared.
util.build_module() uses that function to get a directory to put the source files for a given test in: since util.get_module_dir() caches its result, the option will have f2py use as a build directory the same temporary directory it put the sources in.
I think T2PyTest cleanup will clear the temporary directory.
Test for #29762 with fix suggested by #29762 and #24874