BUG: Change return type of sign(timedelta64) to float64. #30194
+61
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
If this change is accepted, it should not be merged until after 2.4.0 is branched, so it would be in 2.5.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR,
sign(timedelta64)returns afloat64. The ensures that the sign function has the basic propertyx = np.sign(x)*np.abs(x)whenxhas dtypetimedelta64, including the case wherexisNaT.The PR makes the change with no warnings and no deprecation, and it has not been decided that that is OK! So this is a draft PR until a final decision is made about how to resolve gh-8463.
The issue was brought up on the mailing list: https://mail.python.org/archives/list/[email protected]/thread/7ELIJOAAZAMFIGNDAUMOCLXYBRYYKE2Z/
Closes gh-8463.
Closes gh-29496.