-
-
Notifications
You must be signed in to change notification settings - Fork 11.7k
CI: remove (mainly windows) jobs from Azure pipelines #30222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
rgommers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks pretty good, thanks @andyfaff! And the jobs are way faster on GHA than they were on Azure.
I made some inline comments that would be good to address. In addition, it'd be nice to make the job names more consistent, because it's now hard to spot the difference between the two platforms. I'd propose a fixed pattern: compiler, platform, fast/full, BLAS. Which would yield:
- Clang-cl, x86-64, fast, openblas32
- MSVC, x86, fast, no BLAS
- MSVC, arm64, fast, no BLAS
- MSVC, x86-64, full, openblas64
- MSVC, x86-64, fast, openblas32
|
I'm going to close this PR now to do further work on my fork. I'll reopen when it's ready to be evaluated again. |
rgommers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update Andrew, LGTM now modulo one very minor last thing.
|
In it goes, thanks Andrew! |
Removes two windows jobs from Azure Pipelines, transferring them to GHA.