Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[ADD] rental: product page #15238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 19.0
Choose a base branch
from
Open

[ADD] rental: product page #15238

wants to merge 1 commit into from

Conversation

@meval1006
Copy link
Contributor

@meval1006 meval1006 commented Nov 11, 2025

  • Copied and revised the Rental Order information from the Rental home page and made a new Products page under Rental.

Project task: Add Product page

@meval1006 meval1006 requested a review from Felicious November 11, 2025 23:42
@meval1006 meval1006 self-assigned this Nov 11, 2025
@robodoo
Copy link
Collaborator

robodoo commented Nov 11, 2025

Pull request status dashboard

@C3POdoo C3POdoo requested a review from a team November 11, 2025 23:44
Felicious
Felicious reviewed Nov 14, 2025
View reviewed changes
Copy link
Contributor

@Felicious Felicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work on this new doc that you've basically authored from scratch, @meval1006 !!

Incredible work; it's structured well and follows our style (but because writing is subjective, you'll see some comments in the review), and most importantly, it takes the reader through the process from end-to-end! (:

I've completed my content review, so after you take a look at my comments and address whatever you think is reasonable, let's aim for perfect RST formatting + syntax (defined by no errors when you run make fast and make review, passes all CI checks and only 1 commit) when you push this PR up again, and tag me again for the technical/RST formatting review (: it'll be a quick look-over and (hopefully) merge if I don't find anything!

@Felicious Felicious added the 5 label Nov 14, 2025
@meval1006 meval1006 force-pushed the 19.0-rental-products-meval branch from 57647ac to aa818a1 Compare November 14, 2025 21:29
@meval1006
Copy link
Contributor Author

meval1006 commented Nov 14, 2025

@Felicious Hi Felicia, I have revised the page according to your comments. The most significant changes are:

  • Revising the language to detail that this is for a physical product.
  • Reorganized the Create a new physical product section: Added a new note and simplified the Example.

@meval1006 meval1006 requested a review from Felicious November 14, 2025 21:32
@meval1006 meval1006 force-pushed the 19.0-rental-products-meval branch from aa818a1 to 388b55b Compare November 15, 2025 01:33
@meval1006
Copy link
Contributor Author

meval1006 commented Nov 15, 2025

@Felicious, I added a Create an invoice section and revised the Pickup and Return sections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Felicious Felicious Awaiting requested review from Felicious

At least 1 approving review is required to merge this pull request.

Assignees

@meval1006 meval1006

Labels

5

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@meval1006 @robodoo @Felicious