Optimize header fixing logic and improve tests #1036
+55
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9c86966 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
commit: |
vicb
reviewed
Nov 14, 2025
| * @__PURE__ | ||
| */ | ||
| export function fixISRHeaders(headers: OutgoingHttpHeaders) { | ||
| const regex = /s-maxage=(\d+)/; |
Contributor
There was a problem hiding this comment.
nit: do not capture if there is no need (it is slower)
Suggested change
| const regex = /s-maxage=(\d+)/; | |
| const regex = /s-maxage=\d+/; |
vicb
approved these changes
Nov 14, 2025
Contributor
vicb
left a comment
There was a problem hiding this comment.
Thanks for the fix.
LGTM, one nit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor header handling to ensure fixes apply only once and only if necessary. Update tests to validate the new behavior of cache-control headers.
This fixes stale cache control header (for ISR) overriding cache control set in the middleware