fix: improve code group style in RSS #634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for oxc-project ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
e3d0bd2 to
2f1e612
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When rendering code groups, the default renderer generates something like
<input type="radio"><label>npm</label>for switching between tabs, but all JavaScript and CSS are disabled in RSS, and some RSS readers' sanitizers removeinputelements, resulting in something like this in Miniflux:This PR converts code groups into HTML tables like this:
Some irrelevant changes seem to occur in pnpm-lock.yaml after running
pnpm add -D @types/markdown-it @types/markdown-it-container markdown-it-containerand I don't know how to avoid them.I know the implementation is a bit hacky, feel free to close this if it's out of scope.