-
Notifications
You must be signed in to change notification settings - Fork 8k
Enable 64bit integer support on 32bit arch --enable-zend-int64
#19079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
I think this should go through the RFC process. There have been suggestions to drop 32-bit support, so I'm sure at least some people would object to expanding support further. I could see this as an alternative to dropping 32-bit support iff we also dropped 4-byte zend_long support, as that would align 32 and 64-bit. |
|
I have fixed some cases which failed due to SIZEOF_SIZE_T != SIZEOF_ZEND_LONG, but there are probably more. Currently, the test state is as follows: |
Yes, of course. At the current state I want to get to know the work needed to be done and do some benchmarks. For dropping 32-bit support entirely it seems to be to early at least for WebAssembly + there might be people hoping for supporting older (in some cases not that old) systems - so I don't thing it would go through currently. |
4fb8912 to
6b552c1
Compare
e28b737 to
f41823a
Compare
2c3b9d7 to
9cdbff2
Compare
b5231fb to
327a244
Compare
This PR allows to use 64bit integers on 32bit platforms if compiled with
--enable-zend-int64--enable-zend-int64)PHP_SYS_SIZE = [4|8])Zend/tests/andtests/ext/The main part is that
ZEND_ENABLE_ZVAL_LONG64 1gets defined.