Fix bug in $input->urlSegment() when using a wildcard as first character #319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's a weird bug.
For some reason, PHP evaluates this statement to be true:
"*example" < 0
It only happens when an asterisk is at the beginning of the string.
For comparison, this statement is false:
"example" < 0
Because of this, the urlSegment() function proceeds to run the next line in the IF statement, which throws an error when abs() chokes on the given string.
This change would check to make sure the given input is in fact an integer before proceeding to run the code that assumes it was given an integer.
This would allow use of wildcards that start with an asterisk. Currently using $input->urlSegment("*example") throws error.
Contributor
|
Good catch! This must be something which changed in PHP8+: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a weird bug.
For some reason, PHP evaluates this statement to be true:
"*example" < 0It only happens when an asterisk is at the beginning of the string.
For comparison, this statement is false:
"example" < 0Because of this, the
urlSegment()function proceeds to run the next line in the IF statement, which throws an error whenabs()chokes on the given string.This change would check to make sure the given input is in fact an integer before proceeding to run the code that assumes it was given an integer.
This would allow use of wildcards that start with an asterisk. Currently using
$input->urlSegment("*example")throws error.