Add gRPC request duration histogram #235
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@sandersaares, if you have any doubts about this PR, please, let me know |
|
@sandersaares Any update on this PR? Thanks |
|
I rebased this PR to v5.0.1 here: https://github.com/calcasa/prometheus-net/tree/grpc-histogram You can pull that one to update this PR (or replicate the results) |
|
Rebased this PR to 6.0.0 to that same branch |
|
@sandersaares @EraYaN @Mario-Hofstaetter @Sverdel Hi All, I saw another similar PR: #340, not sure which one will be merged, is there any update ? |
|
Rebased this PR to 7.0.0 in https://github.com/calcasa/prometheus-net/tree/grpc-histogram |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think, it would be nice to have duration histogram for grpc request just like for http requests. Unfortunately,
HttpRequestDurationMiddlewarecan't be used, because it know nothing about gRPC method name. So I addGrpcRequestDurationMiddlewareand all infrastructure for it