type stubs for third-party libraries #3443
Draft
+221
−50
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The codebase previously relied on
# type: ignoreand# pyright: ignorecomments to suppress type errors from third-party libraries lacking type hints (llama_cpp,mlx,mlx_lm,outlines,transformers, andvllm).make typecheckfailed due to missing type information frommlxandvllm. Both dependencies are absent in the Linux dev container.Solution
This PR introduces type stub files
.pyifor these libraries. Type stubs provide type information to static type checkers without modifying the runtime behavior.SamplingParamsfromvllm.Alternatively, I can add automation with a
uv run stubgentarget inMakefile.make typechecknow passes successfully in the Linux dev containerAdded
stubs/directory containing type stub files forllama_cpp,mlx,mlx_lm,outlines,transformersandvllm.pyproject.tomlto configure stub search paths forpyrightandmypyChanged
outlines-mlxlmhas been updated in bothpyproject.tomlfiles.uv.lockfile has been updated to reflect these dependency changes.Removed
# pyright: ignoreand# type: ignorecomments fromoutlines.pyandtest_outlines.py.