[antlr4-python3-runtime] Fixed multiple Incomplete #15038
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
Sorry for multiple tests fixing commits. I'm making real typeshed stubs for the first time. |
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
srittau
approved these changes
Nov 17, 2025
Collaborator
srittau
left a comment
There was a problem hiding this comment.
Thanks! Don't worry about the number of commits, this is normal even for experienced typeshed contributors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I started experimenting with ANTLR and Python again and noticed (again) that literally most of ANTLR's runtime internal functions are not fully typed (strict type checkers were screaming because of many “Unknown” or “Incomplete” type annotations instead of correct ones). I've already had to reinvent the wheel twice to get around this problem and make full use of the powerful type annotation system, but those were ugly solutions.
So, I tried my best to fix those type stubs at least particularly. I couldn't fix all “Unknown” or “Incomplete” yet; the ANTLR runtime code is kinda a mess. But I hope a bit later I will understand it enough to fix it entirely.