Engine: support .pragma library for js files #377
Conversation
stephenmdangelo
left a comment
There was a problem hiding this comment.
I don't think this will match Qt QML behaviour for Qt.include, as that should create a copy of the included file, ignoring any pragma statements within it: http://doc.qt.io/qt-5/qtqml-javascript-imports.html#including-a-javascript-resource-from-another-javascript-resource
When importing a JavaScript file into a QML file, wouldn't it be faster/easier to keep a global reference to the context object that is created the first time it is imported (e.g. Whatever is assigned to the "as" variable, as opposed to the "contextSetter" function), and then create a variable with the qualified name inside of the Component context and assign the global object to it?
I think that would require changes outside of loadJS.
|
@stephenmdangelo Thanks. I will check what could be done with I will try to do the other impl (like you proposed) and will compare the two patches on size and complexity (given that |
|
I think for Qt.include, just maintain the old behaviour and ignore the pragma. That's why I think this feature has to go up a level or two to wherever "importJavascriptInContext" is called. It's less the performance (unless a library has a million exports or something), and more just the simplicity. A global object per library that is just referenced by different names in the context of each QML file. In |
Fixes: #375
Testcase is not ready yet.
/cc @stephenmdangelo for #255 and qmlweb/qmlweb-parser#26 — perhaps you would be interested to try this out =).