Timer: make parent not read-only for now #381
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some parts of QmlWeb set .parent property directly, that was causing a conflict and an exception was being thrown. Long-term, we should create a better fix, but this fixes the immediate problem for now, and properties not being read-only when they should causes much less damage than unexpected exceptions on valid qml code.
Member
|
I have this fix on a branch of mine that solves the issue for QObject.$delete. Are there other places you're seeing an exception being thrown for Timer? |
Member
Author
|
@stephenmdangelo Thanks! I will test that commit soon (hopefully today) and will tell you if that works for my original testcase that was failing (it's not a minimal testcase yet). |
Member
Author
|
@stephenmdangelo Full grep: src/modules/QtQuick/Item.js: child.parent = this; // This will also add it to children.
src/modules/QtQuick/Repeater.js: this.parent = meta.parent;
src/modules/QtQuick/Repeater.js: newItem.parent = this.parent;
src/modules/QtQuick/Loader.js: qmlComponent.parent = this;
src/modules/QtQuick/Loader.js: this.item.parent = undefined;
src/modules/QtQuick.Controls/ScrollView.js: newItem.parent = this;
src/qtbase/QObject.js: this.parent = undefined; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some parts of QmlWeb set .parent property directly, that was causing a
conflict and an exception was being thrown.
Long-term, we should create a better fix, but this fixes the immediate
problem for now, and properties not being read-only when they should
causes much less damage than unexpected exceptions on valid qml code.
This still need a testcase.